Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateSafePrepareTransactionRequestParams can't be used on chain where a multisig owns the contracts #222

Open
alxdca opened this issue Oct 30, 2024 · 0 comments

Comments

@alxdca
Copy link

alxdca commented Oct 30, 2024

I've noticed that the example script to setup fast withdrawal was written the assumption that the private key of the chain owner is available.

On prod chains, it's usually a good practice to change ownership to a multisig after deployment.

The createSafePrepareTransactionRequest function which is used to prepare the safe creation transaction requires a Viem PrivateKeyAccount to be passed. This seems unnecessary and could be replaced with 0x${string}.

Ideally the same change would be applied on all functions needed to setup fast withdrawals, allowing these transactions calldata to be easily generated using the SDK and then signed by a multisig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant