feat: Add v1 upgradeExecutor getters #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2024
chrstph-dvx
commented
Jul 11, 2024
chrstph-dvx
force-pushed
the
add-chain-public-actions-decorator
branch
from
c8fe868 to
a57924e
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-getters
branch
3 times, most recently
from
857a41e to
12bbcd7
Compare
fionnachan
reviewed
Jul 19, 2024
There was a problem hiding this comment.
other than hasRole, i think we also want to include upgradeExecutorFetchPrivilegedAccounts?
fionnachan
approved these changes
Jul 19, 2024
chrstph-dvx
force-pushed
the
add-upgradeexecutor-getters
branch
from
d89f21b to
a5c662b
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-getters
branch
2 times, most recently
from
1696a6c to
7bb31d2
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-getters
branch
from
982c700 to
a8c02d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of FS-658