feat: Add v1 ArbOwnerPublic setters #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2024
chrstph-dvx
force-pushed
the
add-arbowner-setters
branch
from
3cdefd5 to
8c5caaa
Compare
fionnachan
reviewed
Jul 19, 2024
src/actions/addChainOwner.ts
Outdated
| import { validateChildChainPublicClient } from '../types/validateChildChainPublicClient'; | ||
|
|
||
| export type AddChainOwnerParameters = Prettify< | ||
| WithUpgradeExecutor< |
There was a problem hiding this comment.
I see a type error in withUpgradeExecutor while reviewing this PR
| ...withUpgradeExecutor({ | ||
| to: arbOwner.address, | ||
| upgradeExecutor, | ||
| args: [recipient], |
There was a problem hiding this comment.
i am wondering if we would like to check the Address type in this function, or outside? currently it is set up to be done outside of this function
what are your thoughts?
chrstph-dvx
force-pushed
the
add-chain-public-actions-setter
branch
2 times, most recently
from
e8786b0 to
4ca765e
Compare
chrstph-dvx
force-pushed
the
add-arbowner-setters
branch
3 times, most recently
from
6b433ea to
2d2793b
Compare
chrstph-dvx
force-pushed
the
add-arbowner-setters
branch
from
ebc3004 to
40c84c4
Compare
chrstph-dvx
force-pushed
the
add-arbowner-setters
branch
from
2c2e174 to
64edde2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of FS-529