Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set up monorepo #554

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

refactor: set up monorepo #554

wants to merge 31 commits into from

Conversation

douglance
Copy link
Contributor

  • minimal change in order to turn the repository into a monorepo.
  • we migrate the project at the root into packages/sdk and move its unique config there
  • we'll split out the scripts folder in a future PR

@douglance douglance requested review from spsjvc and brtkx December 10, 2024 19:14
@cla-bot cla-bot bot added the cla-signed label Dec 10, 2024
@spsjvc spsjvc changed the title feat: sets up monorepo refactor: set up monorepo Dec 13, 2024
yarn.lock Outdated
@@ -1,7 +1,6 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm how did this end up here? can you revert it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was using this to break the cache. fixed 88b994a

.github/workflows/build-test.yml Outdated Show resolved Hide resolved
@@ -87,9 +50,6 @@
"typescript": "^4.9.5",
"yargs": "^17.3.1"
},
"files": [
"dist/**/*"
],
"resolutions": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move resolutions for runtime dependencies to the package's package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it would be nice to have them shared among packages, but I guess it's probably better to just deal with issues individually if they come up. so i moved the resolutions down to the sdk package 88b994a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually, those are all there for audit-ci fixing purposes, so we want them there c80b628

import * as path from 'path'

export const loadEnv = () => {
dotenv.config({ path: path.resolve(__dirname, '../../../../../.env') })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work properly both in the case when you're running commands at the root level of the monorepo, and when you cd into the package and run it there?

Copy link
Contributor Author

@douglance douglance Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does work from both locations. __dirname is the location of this file.

@douglance douglance requested a review from spsjvc December 13, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants