Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: set up monorepo #554
base: main
Are you sure you want to change the base?
refactor: set up monorepo #554
Changes from 22 commits
72ebc46
7523c4a
80db7a8
a96be4c
072e54c
8cfe6fc
349365c
f02b23d
006dd92
b362bb9
4b9749c
9d48d62
4723065
f92e150
1174942
9edac93
9030353
c58abd3
85ec17d
1db4f38
5dc312e
6205d10
121cd2d
88b994a
c80b628
4d06422
36bda6a
5c4e9c6
b2581fc
e602f8f
aa230c2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move resolutions for runtime dependencies to the package's package.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking it would be nice to have them shared among packages, but I guess it's probably better to just deal with issues individually if they come up. so i moved the resolutions down to the
sdk
package 88b994aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh actually, those are all there for audit-ci fixing purposes, so we want them there c80b628
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work properly both in the case when you're running commands at the root level of the monorepo, and when you cd into the package and run it there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does work from both locations.
__dirname
is the location of this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm how did this end up here? can you revert it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was using this to break the cache. fixed 88b994a