Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove connectionState #2014

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

spsjvc
Copy link
Member

@spsjvc spsjvc commented Oct 22, 2024

The only place where it was used is in useImportTokenModal and it didn't need it. Also removed the hook since it's clearer inline.

@cla-bot cla-bot bot added the cla-signed label Oct 22, 2024
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-token-bridge ✅ Ready (Inspect) Visit Preview Oct 22, 2024 10:11am

Copy link
Member

@fionnachan fionnachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a very minor UX issue introduced by this PR.

When user clicks "Cancel", the import token dialog flashes. It doesn't happen on prod right now.

Other than that the code changes LGTM

@spsjvc spsjvc marked this pull request as draft November 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants