Merge pull request #731 from OffchainLabs/retry-value-field

Fix tracing balance deltas
OffchainLabs · Jun 28, 2022 · 6014374 · 6014374
2 parents 12b8c3a + c75fe34
commit 6014374
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/arbos/incomingmessage.go b/arbos/incomingmessage.go
@@ -504,7 +504,7 @@ func parseSubmitRetryableMessage(rd io.Reader, header *L1IncomingMessageHeader,
 		GasFeeCap:        maxFeePerGas.Big(),
 		Gas:              gasLimitBig.Uint64(),
 		RetryTo:          pRetryTo,
-		Value:            callvalue.Big(),
+		RetryValue:       callvalue.Big(),
 		Beneficiary:      callvalueRefundAddress,
 		MaxSubmissionFee: maxSubmissionFee.Big(),
 		FeeRefundAddr:    feeRefundAddress,

diff --git a/arbos/tx_processor.go b/arbos/tx_processor.go
@@ -144,7 +144,7 @@ func (p *TxProcessor) StartTxHook() (endTxNow bool, gasUsed uint64, err error, r
 
 		// mint funds with the deposit, then charge fees later
 		availableRefund := new(big.Int).Set(tx.DepositValue)
-		takeFunds(availableRefund, tx.Value)
+		takeFunds(availableRefund, tx.RetryValue)
 		util.MintBalance(&tx.From, tx.DepositValue, evm, scenario, "deposit")
 
 		transfer := func(from, to *common.Address, amount *big.Int) error {
@@ -170,7 +170,7 @@ func (p *TxProcessor) StartTxHook() (endTxNow bool, gasUsed uint64, err error, r
 		}
 
 		// move the callvalue into escrow
-		if err := transfer(&tx.From, &escrow, tx.Value); err != nil {
+		if err := transfer(&tx.From, &escrow, tx.RetryValue); err != nil {
 			return true, 0, err, nil
 		}
 
@@ -183,7 +183,7 @@ func (p *TxProcessor) StartTxHook() (endTxNow bool, gasUsed uint64, err error, r
 			timeout,
 			tx.From,
 			tx.RetryTo,
-			underlyingTx.Value(),
+			tx.RetryValue,
 			tx.Beneficiary,
 			tx.RetryData,
 		)
@@ -257,7 +257,7 @@ func (p *TxProcessor) StartTxHook() (endTxNow bool, gasUsed uint64, err error, r
 		if evm.Config.Debug {
 			redeem, err := util.PackArbRetryableTxRedeem(ticketId)
 			if err == nil {
-				tracingInfo.MockCall(redeem, usergas, from, types.ArbRetryableTxAddress, tx.Value)
+				tracingInfo.MockCall(redeem, usergas, from, types.ArbRetryableTxAddress, common.Big0)
 			} else {
 				glog.Error("failed to abi-encode auto-redeem", "err", err)
 			}

diff --git a/arbos/util/retryable_encoding_test.go b/arbos/util/retryable_encoding_test.go
@@ -47,7 +47,7 @@ func TestRetryableEncoding(t *testing.T) {
 		GasFeeCap:        big.NewInt(76456),
 		Gas:              37655,
 		RetryTo:          &dest,
-		Value:            big.NewInt(23454),
+		RetryValue:       big.NewInt(23454),
 		Beneficiary:      testhelpers.RandomAddress(),
 		MaxSubmissionFee: big.NewInt(567356),
 		FeeRefundAddr:    testhelpers.RandomAddress(),
@@ -66,7 +66,7 @@ func TestRetryableEncoding(t *testing.T) {
 		innerTx.RequestId,
 		innerTx.L1BaseFee,
 		innerTx.DepositValue,
-		innerTx.Value,
+		innerTx.RetryValue,
 		innerTx.GasFeeCap,
 		innerTx.Gas,
 		innerTx.MaxSubmissionFee,

diff --git a/go-ethereum b/go-ethereum
diff --git a/nodeInterface/NodeInterface.go b/nodeInterface/NodeInterface.go
@@ -142,7 +142,7 @@ func (n NodeInterface) EstimateRetryableTicket(
 		GasFeeCap:        n.sourceMessage.GasPrice(),
 		Gas:              n.sourceMessage.Gas(),
 		RetryTo:          pRetryTo,
-		Value:            l2CallValue,
+		RetryValue:       l2CallValue,
 		Beneficiary:      callValueRefundAddress,
 		MaxSubmissionFee: maxSubmissionFee,
 		FeeRefundAddr:    excessFeeRefundAddress,
+6 −6		core/types/arb_types.go
+6 −5		core/types/transaction_marshalling.go
+4 −0		eth/tracers/logger/logger_arbitrum.go
+2 −0		internal/ethapi/api.go