Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Teams 1:1 signin issue #24

Open
elizathomas opened this issue Aug 14, 2018 · 3 comments
Open

Teams 1:1 signin issue #24

elizathomas opened this issue Aug 14, 2018 · 3 comments

Comments

@elizathomas
Copy link

The signin option does not work in 1:1 / private conversations. It works from within a teams channel. The signin card displays, but am not able to click the sign in button.

@jotrick
Copy link
Contributor

jotrick commented Aug 15, 2018

Hello,

Sorry to hear you are having difficulties with the feature. For starters, I'm assuming you are talking about the button with the sign in action (there are specific "sign in" card types, but I don't believe this project makes use of them). If that is the case, what I would recommend is making sure your manifest has the domain of the page you are trying to open in the valid domains list. If it is working in a channel, then you have the domain there, but you need to make sure it is in all of the manifests for that specific bot.id for it to be allowed to open everywhere.

@elizathomas
Copy link
Author

Thank you for the response @jotrick . I was referring to the PopupSigninCardDialog sign in action. Could you please explain- "make sure it is in all of the manifests for that specific bot.id". I have only one manifest file as below. The Bot.Builder SDK version is 3.14.0.7.

{
"$schema": "https://statics.teams.microsoft.com/sdk/v1.3.0-beta.2/manifest/MicrosoftTeams.schema.json",
"manifestVersion": "1.3",
"version": "1.3",
"id": "appid",
"packageName": "com.skype.teams.samples.sampleapp",
"developer": {
"name": "Microsoft",
"websiteUrl": "https://www.microsoft.com",
"privacyUrl": "https://www.microsoft.com/privacy",
"termsOfUseUrl": "https://www.microsoft.com/termsofuse"
},
"name": {
"short": "Sample-App-csharp",
"full": "Sample-App-csharp"
},
"description": {
"short": "This is a small sample app we made for you!",
"full": "This is a small sample app we made for you! This app has samples of all capabilities MS Teams supports."
},
"icons": {
"outline": "bot_blue.png",
"color": "bot_blue.png"
},
"accentColor": "#3F487F",
"staticTabs": [
{
"contentUrl": "https://0b0046eb.ngrok.io/public/tab/tabConfig/tab.aspx",
"entityId": "statictab",
"name": "Bot Info",
"scopes": [
"team",
"personal"
]
}
],
"configurableTabs": [
{
"configurationUrl": "https://0b0046eb.ngrok.io/public/tab/tabConfig/index.html",
"canUpdateConfiguration": false,
"scopes": [ "team", "groupchat" ]
}
],
"bots": [
{
"botId": "appid",
"isNotificationOnly": false,
"scopes": [ "team", "personal", "groupchat" ],
"commandLists": [
{
"scopes": [
"team"
],
"commands": [
{
"title": "help",
"description": "To show the list of command for user interactions"
},
{
"title": "hello",
"description": "Runs the simplest hello dialog"
},
{
"title": "multi dialog 2",
"description": "Displays a card with invoke buttons"
},
{
"title": "roster",
"description": "Fetches the full roster payload for the current conversation"
},
{
"title": "names",
"description": "Lists the names of the users for the current conversation"
},
{
"title": "last dialog",
"description": "Shows which dialog sent the last message"
},
{
"title": "send message to 1:1",
"description": "Send the user a 1:1 message"
},
{
"title": "setup text message",
"description": "Sets up a text message that can be updated"
},
{
"title": "update text message",
"description": "Updates a text message once it is setup to be updated"
},
{
"title": "setup card message",
"description": "Sets up a card that can be updated"
}
]
},
{
"scopes": [
"personal"
],
"commands": [
{
"title": "help",
"description": "To show the list of command for user interactions"
},
{
"title": "hello",
"description": "Runs the simplest hello dialog"
},
{
"title": "multi dialog 2",
"description": "Displays a card with invoke buttons"
},
{
"title": "roster",
"description": "Fetches the full roster payload for the current conversation"
},
{
"title": "names",
"description": "Lists the names of the users for the current conversation"
},
{
"title": "last dialog",
"description": "Shows which dialog sent the last message"
},
{
"title": "send message to 1:1",
"description": "Send the user a 1:1 message"
},
{
"title": "setup text message",
"description": "Sets up a text message that can be updated"
},
{
"title": "update text message",
"description": "Updates a text message once it is setup to be updated"
},
{
"title": "setup card message",
"description": "Sets up a card that can be updated"
}
]
}
]
}
],
"composeExtensions": [
{
"botId": "appid",
"scopes": [
"personal",
"team"
],
"canUpdateConfiguration": true,
"commands": [
{
"id": "search123",
"description": "Find a card",
"title": "Search",
"initialRun": true,
"parameters": [
{
"title": "query123",
"name": "query",
"description": "Search string"
}
]
}
]
}
],
"permissions": [
"identity",
"messageTeamMembers"
],
"validDomains": [
"0b0046eb.ngrok.io",
"token.botframework.com"
]
}

@jotrick
Copy link
Contributor

jotrick commented Aug 16, 2018

The first thing to check (and I'm assuming this is correct because it is working elsewhere, but it is nice start with easy things) is that 0b0046eb.ngrok.io is the current ngrok endpoint you are running.

Second, with this manifest, have you sideloaded it personally for yourself? What I mean by this is, if you go to the "..." in the left rail, do you see this app or are you only talking to this bot in the chat view? If you don't see it (and you can do this anyway just as another double check), go to the store, go to the bottom left hand corner, click on "Upload a custom app", select your zip package, and install it for yourself. This may be what you need to get the valid domains list to be registered for you personally. (and as a quick addition - using the app "App Studio" from the store can really help managing your app definitions for development)

Please, just let me know if this solves your issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants