From 622a928050c71dcea9a8db92f4d102c8032c7b7c Mon Sep 17 00:00:00 2001 From: Huajie Zhang Date: Mon, 29 Apr 2024 11:11:11 +0800 Subject: [PATCH] refactor: spfx generator component name (#11502) --- .../fx-core/src/component/generator/spfx/spfxGenerator.ts | 3 ++- .../src/component/generator/templates/templateGenerator.ts | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/fx-core/src/component/generator/spfx/spfxGenerator.ts b/packages/fx-core/src/component/generator/spfx/spfxGenerator.ts index 811568afa7..bf4cedc6b8 100644 --- a/packages/fx-core/src/component/generator/spfx/spfxGenerator.ts +++ b/packages/fx-core/src/component/generator/spfx/spfxGenerator.ts @@ -885,6 +885,7 @@ export class SPFxGenerator { } export class SPFxGeneratorNew extends DefaultTemplateGenerator { + componentName = "spfx-new-generator"; public activate(context: Context, inputs: Inputs): boolean { const capability = inputs[QuestionNames.Capabilities] as string; const spfxSolution = inputs[QuestionNames.SPFxSolution]; @@ -913,8 +914,8 @@ export class SPFxGeneratorNew extends DefaultTemplateGenerator { } export class SPFxGeneratorImport extends DefaultTemplateGenerator { + componentName = "spfx-import-generator"; importDetails: string[] = []; - public activate(context: Context, inputs: Inputs): boolean { const capability = inputs[QuestionNames.Capabilities] as string; const spfxSolution = inputs[QuestionNames.SPFxSolution]; diff --git a/packages/fx-core/src/component/generator/templates/templateGenerator.ts b/packages/fx-core/src/component/generator/templates/templateGenerator.ts index 49c9fff9bc..9f73ea7ad3 100644 --- a/packages/fx-core/src/component/generator/templates/templateGenerator.ts +++ b/packages/fx-core/src/component/generator/templates/templateGenerator.ts @@ -56,7 +56,7 @@ export class DefaultTemplateGenerator implements IGenerator { return ok(undefined); } - // override this method to provide information of templates to be generated + // override this method to 1) do pre-step before template download and 2) provide information of templates to be downloaded public getTemplateInfos( context: Context, inputs: Inputs, @@ -68,7 +68,7 @@ export class DefaultTemplateGenerator implements IGenerator { return Promise.resolve(ok([{ templateName, language }])); } - // override this method to do post process + // override this method to do post-step after template download public post( context: Context, inputs: Inputs,