Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noice and conjure doesn't integrate well: input area blinks when evaluating the form. #450

Open
glyh opened this issue Dec 22, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@glyh
Copy link

glyh commented Dec 22, 2022

Here's a record
asciicast

@glyh
Copy link
Author

glyh commented Dec 22, 2022

I don't know if it's a bug on either side, maybe I should post on their side.

@Olical
Copy link
Owner

Olical commented Jan 7, 2023

Recording got deleted because it wasn't associated with an account 😞

@glyh
Copy link
Author

glyh commented Jan 8, 2023

Will reproduce...

@thecontinium
Copy link

I predominantly use conjure for clojure and don't see any flashing with Noice.
With a python client I do see the message ui flash on and off after every evaluation.

@thecontinium
Copy link

The flashing in noice that I am seeing is when a command is given via a key mapping.
Every time the key mapping is used the command mapped flashes up in Noice. I would like to stop this.

I currently set my keymaps in Lua like this:

vim.g["conjure#mapping#prefix"] = ","
vim.g["conjure#mapping#log_split"] = "lv"
vim.g["conjure#mapping#log_toggle"] = "ls"
vim.g["conjure#mapping#log_vsplit"] = "lg"

Please see here for disabling cmd line popup for keymaps in noice
@Olical is there a way in conjure to make key mapping more explicit so that they can be mapped as silent or with cmd as suggested ?

@Olical
Copy link
Owner

Olical commented Apr 3, 2023

Just tried swapping : prefixes to <cmd> on develop and it still seems to work fine for me. What do you think? Sorry it's taken a while, I had a weeks holiday and then a weeks sickness and still don't feel great 😓 hopefully this helps. All mappings are already marked as silent, it's just that they map to Lua callbacks that then invoke :normal! :...<cr> which seems to cause your issue.

They now map to :normal! <cmd>...<cr> as documented in that link, thanks, that's a new one to me!

@glyh
Copy link
Author

glyh commented Apr 3, 2023

No worries, you're good. I hope you will feel better soon!

I just tried the develop branch. I can evaluate (+ 1 2 3) with <leader>er, but using visual mode and evaluate yields this:

E5108: Error executing lua: Vim:Error executing Lua callback: ...m/site/pack/packer/start/conjure/lua/conjure/extract.lua:92: Vim(normal):E20: Mark not set
stack traceback:
	[C]: in function 'normal'
	...m/site/pack/packer/start/conjure/lua/conjure/extract.lua:92: in function 'selection'
	...nvim/site/pack/packer/start/conjure/lua/conjure/eval.lua:318: in function <...nvim/site/pack/packer/start/conjure/lua/conjure/eval.lua:317>
	[C]: at 0x55f244597360
stack traceback:
	[C]: at 0x55f244597360

There's no such bug in master branch, tho.

@Olical
Copy link
Owner

Olical commented Apr 3, 2023

Ah crap, good catch! I'll look at that tomorrow. If <cmd> fixes this clash with this other plugin and makes it fully silent I'll find a way to work that into the visual mode one too.

@Olical Olical added the bug Something isn't working label Apr 4, 2023
@Olical
Copy link
Owner

Olical commented Apr 4, 2023

Only using <cmd> for normal mode mappings now.

@thecontinium
Copy link

Thanks @Olical - hope you’re feeling better. I’ll give it a test run too.

@thecontinium
Copy link

Evaluate: buffer, form, mark and motion - no flashing.

Evaluate: selection still flashes up the cmd line popup.

@Olical
Copy link
Owner

Olical commented Apr 5, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants