Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change C++ handling of lists from stl to buffer protocol #11

Open
OlivierBinette opened this issue Apr 2, 2022 · 1 comment
Open

Change C++ handling of lists from stl to buffer protocol #11

OlivierBinette opened this issue Apr 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@OlivierBinette
Copy link
Owner

OlivierBinette commented Apr 2, 2022 •
edited
Loading

Currently, every list passed to a StringCompare function is copied before operations are applied. This is due to the use of stl containers as input types and implicit conversions done by pybind11 (see https://pybind11.readthedocs.io/en/stable/advanced/cast/stl.html).

It would be best to have StringCompare vectorized functions take buffer protocol objects as arguments, to avoid any copying and improve efficiency.
@OlivierBinette OlivierBinette added the enhancement New feature or request label Apr 2, 2022
@OlivierBinette
Copy link
Owner Author

Need to balance performance with maintainability, extensibility and portability of the C++ library... Not sure what to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OlivierBinette