Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proper separation between Python and C++ code #4

Open
OlivierBinette opened this issue Mar 31, 2022 · 0 comments
Open

Create proper separation between Python and C++ code #4

OlivierBinette opened this issue Mar 31, 2022 · 0 comments
Milestone

Comments

@OlivierBinette
Copy link
Owner

Currently, the package uses the C++ code by default and leaves the use of the pure Python implementation to the discretion of the user.

It might be better to more clearly separate the Python and C++ implementation. Some ideas:

  • provide separate "strincompare" and "cstringcompare" packages,
  • at package load time, try using C++ implementation and fall back on the pure Python implementation if loading fails.

There are also some issues with having all C++ code in headers. Compilation is still very quick but I'm not sure how it will scale as the package grows. It would also be nice to be able to provide the C++ code as a C++ library which is independent of the Python implementation...

We'll see what refactoring is needed as the package grows.

@OlivierBinette OlivierBinette added this to the Packaging milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant