Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Subscriptions compatibility #1

Open
lkraav opened this issue Nov 22, 2023 · 3 comments
Open

Add Subscriptions compatibility #1

lkraav opened this issue Nov 22, 2023 · 3 comments
Assignees
@OllieJones
Labels
enhancement New feature or request

Comments

@lkraav
Copy link

lkraav commented Nov 22, 2023

Exactly the same thing is happening at Automattic/woocommerce-subscriptions-core#183
@OllieJones OllieJones self-assigned this Nov 24, 2023
@OllieJones OllieJones added the enhancement New feature or request label Nov 24, 2023
@OllieJones
Copy link
Owner

OllieJones commented Nov 24, 2023 •
edited
Loading

Indeed this is the same issue as order search -- the notorious nonsargable column LIKE '%searchterm%' performance antipattern.

@lkraav
Copy link
Author

lkraav commented Jul 15, 2024

Thoughts on getting this in? Do you need a copy of the plugin perhaps?

@lkraav
Copy link
Author

lkraav commented Jul 15, 2024

Is this already fixed with

fast-woo-order-lookup/fast-woo-order-lookup.php

Line 112 in d945f3f

add_filter( 'woocommerce_shop_subscription_search_fields', array( $this, 'filter_search_fields' ) );
🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OllieJones OllieJones

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkraav @OllieJones