Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla drop and power drop being bound to the same key causes both to execute simultaneously (1.12.2) #6

Open
EliteMeats opened this issue Jul 30, 2023 · 3 comments
Assignees

Comments

@EliteMeats
Copy link

EliteMeats commented Jul 30, 2023

When both the vanilla drop keybind and power drop keybind are on the same key, it causes both to activate at the same time. While this specific issue goes away once the vanilla drop is bound to something else, this also means the vanilla drop cannot be used at all (for example, while hovering over items and pressing Q in the inventory). Ideally power drop should still be usable when bound to the same key as vanilla drop; it should just detect if the user is holding the drop key, for example. This bug is present in the mod for 1.12.2; I do not know if it is present in newer versions as well.

image

power.drop.bug.mp4
@OmegaJak
Copy link
Owner

Yeah, I've never had a great answer for how this should interact with the vanilla drop keybind. I'll give that some more thought.

Interestingly, I'm not seeing this same behavior with Minecraft 1.12.2 and the "MC1.12.2-1.1.2" version of Power Drop (with Forge 14.23.5.2859). Are you using the same versions of the mod and forge as I am? I'm curious why I can't seem to reproduce this behavior.

This problem is present on the 1.18-1.20 versions, if bound to the same key (though it drops many items like the vanilla drop does if held).

As a workaround, does binding Power Drop to Shift+Q and leaving vanilla drop on Q solve it for you on 1.12.2?

@OmegaJak
Copy link
Owner

OmegaJak commented Jul 30, 2023

I specifically addressed this issue in the 1.18-1.20 versions (2.0.1, 2.1.2, and 2.2.1), but haven't yet on the 1.12 version. The fix I used on the newer versions won't work on 1.12, so let me know if the workaround above is sufficient.

@OmegaJak OmegaJak self-assigned this Aug 9, 2023
@EliteMeats
Copy link
Author

EliteMeats commented Aug 12, 2023

Hi, sorry for the late response!

Interestingly, I'm not seeing this same behavior with Minecraft 1.12.2 and the "MC1.12.2-1.1.2" version of Power Drop (with Forge 14.23.5.2859). Are you using the same versions of the mod and forge as I am? I'm curious why I can't seem to reproduce this behavior.

In the video above I was using version "MC1.12.2-1.1.2", but was using Forge 14.23.5.2860. Not sure if that would somehow affect it, but yeah.

As a workaround, does binding Power Drop to Shift+Q and leaving vanilla drop on Q solve it for you on 1.12.2?

It does; I bound it to Alt+Q for my purposes, but it's the same thing functionally, so I guess that actually sort of fixes the issue. I had no idea you could bind things to two keys; would've been very helpful to know that before lol.

I honestly wasn't expecting such a fast resolution, since a lot of modders abandon their 1.12.2 versions, so thanks again for jumping on this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants