Skip to content
This repository has been archived by the owner on Feb 13, 2019. It is now read-only.

Fix race-condition in grunt-bower-task #254

Closed
peterblazejewicz opened this issue Jul 2, 2015 · 2 comments
Closed

Fix race-condition in grunt-bower-task #254

peterblazejewicz opened this issue Jul 2, 2015 · 2 comments
Labels
completed enhancement

Comments

@peterblazejewicz
Copy link
Member

By default grunt-bower-task will remove (clean) installed Bower package and try to copy it, this leads to race-condition:

grunt
Running "bower:install" (bower) task
>> Installed bower packages
Fatal error: ENOENT, no such file or directory 'wwwroot/lib/jquery-validation

The fix is to not copy already installed packages - as the same directory is used in .bowerrc config and in grunt-bower-task targetDir option.
Similar:
yatskevich/grunt-bower-task#134
@peterblazejewicz peterblazejewicz mentioned this issue Jul 2, 2015
Merged
@peterblazejewicz
Copy link
Member Author

as a comment: before beta5 all client-side templates were included with source of template - so no Bower managed installation have been ocurring during installation. After beta5, all client side dependencies are installed via Bower (as part of build process or via Grunt task).

peterblazejewicz added a commit that referenced this issue Jul 6, 2015
@peterblazejewicz
Merge pull request #257 from Spinarooni/race-cond-fix-issue-254
e0c6e67 
Fix race condition with grunt bower-install task.  Fixes issue #254.
@Spinarooni 🙇
@sayedihashimi sayedihashimi mentioned this issue Jul 7, 2015
Closed
@peterblazejewicz
Copy link
Member Author

closed via: 96e1c17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
completed enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterblazejewicz