Make Schema Registry Subjects configurable #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ZK lib in provided scope. Added property for jersey.bean.validation version
…r destination Schema Registry
…tegy and TopicRecordNameSubjectStrategy
…alue.subject.name.strategy parameters
Comment on lines
-124
to
+135
| // TODO: Make the Strategy configurable, may be different for src and dest | ||
| // Strategy for the -key and -value subjects | ||
| this.subjectNameStrategy = new TopicNameStrategy(); | ||
| // Strategy for the subjects | ||
| this.keySubjectNameStrategy = createSubjectStrategy(config.getString(ConfigName.KEY_SUBJECT_NAME_STRATEGY)); | ||
| this.valueSubjectNameStrategy = createSubjectStrategy(config.getString(ConfigName.VALUE_SUBJECT_NAME_STRATEGY)); |
There was a problem hiding this comment.
Sorry it took me so long to review this.
Were you not able to make the source and destination use differing strategies? Or do you think that use case would ultimately cause confusion?
| <confluent.patch.version>-cp1</confluent.patch.version> | ||
| <jackson.version>2.9.7</jackson.version> | ||
| <jackson.asl.version>1.9.13</jackson.asl.version> | ||
| <confluent.version>5.5.0</confluent.version> |
There was a problem hiding this comment.
It should be possible to implement the feature without upgrades, IMO.
Can the version bump be a separate PR?
Comment on lines
+896
to
+898
| assertTrue(destKeyVersions.isEmpty(), "the destination registry starts empty"); | ||
| List<Integer> destValueVersions = destClient.getAllVersions(destValueSubject); | ||
| assertTrue(destValueVersions.isEmpty(), "the destination registry starts empty"); |
There was a problem hiding this comment.
nit: The message needs changed since you've already registered something in the destination
Comment on lines
+841
to
+843
| String destKeySubject = TOPIC + "-" + keySchema.name(); | ||
| //value subject in destination schema registry is topic-record name, NOT default topicName-value | ||
| String destValueSubject = TOPIC + "-" + valueSchema.name(); |
There was a problem hiding this comment.
Would it be possible to use TopicRecordNameStrategy to create these rather than manually?
Comment on lines
+849
to
+855
| log.info("Registering schemas in source registry"); | ||
| int sourceKeyId = sourceSchemaRegistry.registerSchema(TOPIC, true, keySchema); | ||
| final String keySubject = TOPIC + "-key"; | ||
| assertEquals(1, sourceKeyId, "An empty registry starts at id=1"); | ||
| int sourceValueId = sourceSchemaRegistry.registerSchema(TOPIC, false, valueSchema); | ||
| final String valueSubject = TOPIC + "-value"; | ||
| assertEquals(2, sourceValueId, "unique schema ids monotonically increase"); |
There was a problem hiding this comment.
Worth adding some comment that this is using TopicNameStrategy?
| @@ -152,22 +154,22 @@ public void beforeEach(final ExtensionContext context) { | |||
| .willReturn(WireMock.aResponse().withTransformers(this.getVersionHandler.getName()))); | |||
| this.stubFor.apply(WireMock.get(WireMock.urlPathMatching(CONFIG_PATTERN)) | |||
| .willReturn(WireMock.aResponse().withTransformers(this.getConfigHandler.getName()))); | |||
| this.stubFor.apply(WireMock.get(WireMock.urlPathMatching(SCHEMA_BY_ID_PATTERN + "\\d+")) | |||
| this.stubFor.apply(WireMock.get(WireMock.urlPathMatching(SCHEMA_BY_ID_PATTERN + "\\d+/(?:fetchMaxId=false)")) | |||
There was a problem hiding this comment.
Dont think the capture group is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Was planning to make this PR after #26 is merged, but doing it anyway.