-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mm2 updates #26
base: master
Are you sure you want to change the base?
Mm2 updates #26
Conversation
Thank you! Overall makes sense. Few comments. Otherwise, I'm not sure I understand why it was ultimately needed... MM2 should work on its own since this SMT doesn't package anything but Avro and the Registry client, which the HTTP client hasn't changed that much, and it's shaded here too |
… ZK lib in provided scope. Added property for jersey.bean.validation version
Updated PR according to comments here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please bump the pom version as well?
Version bumped to v.0.2.1 |
Given that this PR has been approved, can @OneCricketeer please merge it and build new 0.2.1 version? |
are you going to merge that? |
Mm2 updates (Copy of OneCricketeer#26)
Hi all, I no longer use Kafka for my role, nor this SMT, so am not actively looking at maintaining it. That being said, Confluent has documentation about migrating schemas, and I am curious if anyone has tried those methods and has feedback on how they differ from this repo? |
update to latest master version
The approach listed here involves setting the schema registry into a special mode where you can specify the id of the schema when you load it. This does work and you can use mirror maker without this SMT and then some other program to simply push the existing schema and id's in Limitations
I like your approach and think it's odd that it's not part of mirror maker Limitations of this approach
my quick fix is to add an ignore list: iturcino#2 I'm tempted to think it would be better for my use case if it simply ignored the not found or bad magic number |
anyone can review and merge it? |
Fixes #25