Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This FCM bump requires
compileSdkVersion 34
, so we may want to defer it until it is more common or find a way to not require it for customers.One Line Summary
Bump default version of firebase-messaging to 24.0.0.
Details
firebase-messaging
has always includedplay-services-base
but in24.0.0
they changed this to runtime. This means we needed to start includingplay-services-base
in ourbuild.gradle
, however we are doing so ascompileOnly
so we don't upgrade or downgrade the version in the customer's app.Motivation
We should default the newest tested versions of our dependencies so we get the latest fixes.
Scope
Only upgrading for firebase-messaging.
Testing
Manual testing
Tested on an Android 14 emulator, ensuring it subscribes to FCM and gets a pushToken.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is