Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest dependencies #5

Open
asialgearoid opened this issue Jul 13, 2018 · 3 comments
Open

Update to the latest dependencies #5

asialgearoid opened this issue Jul 13, 2018 · 3 comments
Assignees

Comments

@asialgearoid
Copy link

This example is very outdated, and the dependencies need to be updated to the latest versions. That includes, the Onsen UI core, Angular 6, and the Angular bindings.

@puku0x Do you think this is something you could do? You have a much better idea than me what has changed between Angular versions. It's definitely not a high priority task, but if you have some free time in the next few months, this would be a great thing to get done.

@puku0x
Copy link
Collaborator

puku0x commented Jul 13, 2018

@asialgearoid Yes I can.
I made a sample inspired by the vue-onsenui-kitchensink before.
https://github.com/puku0x/ngx-onsenui-kitchensink
I will update this Angular example based on it!

@asialgearoid
Copy link
Author

Oh, that's great! Since this is already so out of date, I would be happy for you to just copy the code from your own kitchensink into this repository. Alternatively, you could transfer puku0x/ngx-onsenui-kitchensink to OnsenUI. You could continue to maintain it as the official kitchensink, and we could archive this one.

Do you have a preference as to which option to take? I think the transfer would be simpler, but I completely understand if you would prefer to keep it as a personal project.

@puku0x
Copy link
Collaborator

puku0x commented Jul 13, 2018

@asialgearoid
I would like to chose the second option.
I will transfer my kitchensink to OnsenUI later.

@puku0x puku0x self-assigned this Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants