You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When linting the OAP definitions, I found the following points which appear in equipment definitions but don't have a matching definition in a points file. I am happy to add the missing definitions but I'm not sure what all of them are, to be honest.
DVST: something to do with VFDs? I couldn't figure this one out.
ENERGY: appears on FCUVRFZC and UPS. Doesn't seem the same as ENERGYNET, --> make a new point definition ENERGY "energy, sensor,total"
EVPRRLT: --> use EVPRFLT?
HWBPVCMD: is this a "hot water boiler valve command"? It's on the HWPL (hot water plant).
ILLUM: seems pretty similar to LTPC although it's not really a photocel (this is on CAM) --> use LTPC.
OCCST: eg on ACU. --> use OCCEFFSP?
RAPWR: eg on PDU. --> use REACPWR?
VFB: on CHB. Seems like there are a few valve feedbacks (CWVFBK). What valves does a chilled beam have?
WDWSW: on CHB. Is this a window switch (WDST)?
LTLVLSP: is this needed or can all the instances be changed to EFLTLVLSP?
The text was updated successfully, but these errors were encountered:
stevedh
added a commit
to normalframework/ontology
that referenced
this issue
Apr 12, 2023
This commit starts to add additional linting for the OAP, in order to
validate the structure and content of the documents. There are two
pieces to this commit:
* Structural linting uses yamale to validate the OAP data against
yaml schema for equipment, points, and tags files. The schemas are
based on the actual data present and so might not be exactly what
the designers intended; but prevent indentation errors.
* Spellchecking runs cspell on the text. Identifiers and other words must be
added to lint/ids.txt or the build will fail.
* Two github workflows which run these linters on commit.
In the future, we should add additional check; eg to ensure each point
has a definition (see OntologyAlignmentProject#2); but until that issue is closed the test
would fail anyways.
When linting the OAP definitions, I found the following points which appear in equipment definitions but don't have a matching definition in a points file. I am happy to add the missing definitions but I'm not sure what all of them are, to be honest.
The text was updated successfully, but these errors were encountered: