Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Remove 2-digit length validation on CountrySubdivionCode #442

Open
arthur-clara opened this issue Jun 29, 2023 · 3 comments · May be fixed by #479
Open

[Enhancement]: Remove 2-digit length validation on CountrySubdivionCode #442

arthur-clara opened this issue Jun 29, 2023 · 3 comments · May be fixed by #479
Assignees
Labels
enhancement New feature or request

Comments

@arthur-clara
Copy link
Collaborator

Description of Enhancement :

Change the regex pattern to remove the digit length restriction or increase the length to at least 4 digits. (So, allow entries between 2 and 4 digits inclusive: ^[A-Z0-9]{1,5}$

Why is this Needed?

Right now, the countrySubdivisionCode variable is a string that must match regex pattern: ^[A-Z0-9]{1,3}$

This works for US ISO 3166-2 subdivisions (a.k.a. States), but it does not work in countries where the jurisdiction does not match the US ISO 3166-2 codes.

For example, two key startup jurisdictions in the UAE are: "Abu Dhabi Global Market" (ADGM) and "Dubai International Financial Centre" (DIFC). It is impossible to put these jurisdictions into 2 digit format.

Anything else we need to know?

If we want to keep countrySubdivisionCode as 2 digits to validate properly for the US, then we could add an additional optional variable to the Issuer object called "jurisdiction" or something like that.

@arthur-clara arthur-clara added the enhancement New feature or request label Jun 29, 2023
@JSv4
Copy link
Contributor

JSv4 commented Jul 11, 2023

Change is ok per TWG. Also, action item, look into being able to have mixin validations for regional validation - e.g. we can add the 3166-2 back in where desired for strict us compatibility OR have separate validations for other non-US jurisdictions that might have other requirements.

@JSv4
Copy link
Contributor

JSv4 commented Feb 13, 2024

Hey @arthur-clara, going through some old issues. You think you'll have time to get to this one?

@arthur-clara
Copy link
Collaborator Author

@JSv4 Yeah. I can pick this back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants