Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasterio dependency #340

Closed
soxofaan opened this issue Feb 14, 2023 · 7 comments
Closed

rasterio dependency #340

soxofaan opened this issue Feb 14, 2023 · 7 comments

Comments

@soxofaan
Copy link
Member

'rasterio~=1.1.8',

The only place rasterio is used in main project is at

def _save_stitched_tiled(self, spatial_rdd, filename):
import rasterio as rstr
from affine import Affine
import rasterio._warp as rwarp

But as far as I can see, this _save_stitched_tiled is not used anymore (last usage removed in 8e3652f ?)

rasterio is however used in a couple of unit tests

So I think we can just drop rasterio as install_requires dependency and move it to the test dependencies

@soxofaan
Copy link
Member Author

@jdries ok to drop rasterio as install_requires dependency, and remove _save_stitched_tiled?

@soxofaan
Copy link
Member Author

cc @EmileSonneveld

@EmileSonneveld
Copy link
Contributor

My problem with rasterio got fixed by switching from Python 3.10 to 3.8.

@jdries
Copy link
Contributor

jdries commented Feb 14, 2023

Ok as proposed!

@soxofaan
Copy link
Member Author

hmm apparently rasterio is an undeclared dependency of geopyspark

will revert

soxofaan added a commit that referenced this issue Feb 15, 2023
@soxofaan
Copy link
Member Author

@soxofaan
Copy link
Member Author

fixed for now

ideally we fix the dependency declaration bug in our custom fork https://github.com/Open-EO/geopyspark , but that's probably not worth the effort for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants