Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resilience against ES log collection issues in CI contexts #560

Open
soxofaan opened this issue Nov 2, 2023 · 2 comments
Open

Comments

@soxofaan
Copy link
Member

soxofaan commented Nov 2, 2023

From time to time openeo-geopyspark-driver unit tests or integration tests fail because of ES log collection failures. For example something like

Job error logs: [{'id': '', 'code': 'Internal', 'level': 'error', 'message': "Log collection for job j-231102dbf0e4490692a4a7dc66ada773 failed. (req_id: r-23110211582f43ac92e799380c550328) OpenEOApiException(status_code=504, code='Internal', message='Temporary failure while retrieving logs: ConnectionTimeout. Please try again and report this error if it persists. (ref: no-request)', id='no-request')"}]

In most cases, the error logs are not relevant in any way for the test itself, and failure to get them due to uncontrollable root cause should not fail the whole test.

@soxofaan
Copy link
Member Author

soxofaan commented Nov 2, 2023

e.g. @JeroenVerstraelen you added Open-EO/openeo-geopyspark-integrationtests@abed154 in the integration tests which automatically fetches error logs (the job.logs(level='ERROR') there) when something is unexpected, but when getting the error logs fails the original issue is obfuscated.

@soxofaan
Copy link
Member Author

soxofaan commented Nov 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant