Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"target_dimension" in aggregate_spatial #951

Open
soxofaan opened this issue Nov 28, 2024 · 2 comments
Open

"target_dimension" in aggregate_spatial #951

soxofaan opened this issue Nov 28, 2024 · 2 comments

Comments

@soxofaan
Copy link
Member

@Pratichhya raised question what "target_dimension" in "aggregate_spatial" is for, it doesn't seem to do anything.

background info:

We don't seem to implement it, so I think we better throw an "not implemented" error at the moment when a user tries to use it instead of blindly doing nothing

soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Nov 28, 2024
@Pratichhya
Copy link

To give more context on my side, I confused it as a process that will help me rename the band label(https://open-eo.github.io/openeo-python-client/api.html#openeo.rest.datacube.DataCube.aggregate_spatial) that we get as a result of aggregate_spatial.

For example, rename the unnamed_band from this notebook to an ndvi.

soxofaan added a commit that referenced this issue Nov 28, 2024
@soxofaan
Copy link
Member Author

I just added some FeatureUnsupportedException to at least make it more clear we don't support it at the moment

soxofaan added a commit that referenced this issue Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants