Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging instead of print #49

Closed
clausmichele opened this issue Jul 13, 2023 · 1 comment · Fixed by #52
Closed

logging instead of print #49

clausmichele opened this issue Jul 13, 2023 · 1 comment · Fixed by #52
Labels
help wanted Extra attention is needed

Comments

@clausmichele
Copy link
Member

Similarly to the logging improvements done for openeo-processes-dask here: Open-EO/openeo-processes-dask#128
I think we should also do the same for this project, since using print is not ideal:

openeo-pg-parser-networkx/openeo_pg_parser_networkx/graph.py

Line 221 in bf8be1e

print(f"Walking node {self._EVAL_ENV.node_uid}")

@LukeWeidenwalker
Copy link
Contributor

Good idea!

@LukeWeidenwalker LukeWeidenwalker added the help wanted Extra attention is needed label Jul 13, 2023
@LukeWeidenwalker LukeWeidenwalker mentioned this issue Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace print statements by logger calls Open-EO/openeo-pg-parser-networkx
2 participants
@LukeWeidenwalker @clausmichele