Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce_spatial #164

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

clausmichele
Copy link
Member

reduce_spatial was not working due to wrong parameters. I fixed it and added a test.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #164 (9a4c0e4) into main (2c72406) will increase coverage by 0.77%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   79.66%   80.44%   +0.77%     
==========================================
  Files          29       29              
  Lines        1254     1268      +14     
==========================================
+ Hits          999     1020      +21     
+ Misses        255      248       -7     
Files Coverage Δ
...esses_dask/process_implementations/cubes/reduce.py 95.65% <ø> (+17.39%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@GeraldIr GeraldIr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, otherwise lgtm.

@clausmichele clausmichele requested a review from GeraldIr October 2, 2023 09:11
@clausmichele
Copy link
Member Author

@GeraldIr thanks, I fixed what you commented.

@ValentinaHutter ValentinaHutter merged commit 6e77c76 into Open-EO:main Oct 11, 2023
@clausmichele clausmichele deleted the fix_reduce_spatial branch November 2, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants