Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of GeometryCollection #389

Closed
m-mohr opened this issue Oct 9, 2022 · 3 comments · Fixed by #395 or #382
Closed

Get rid of GeometryCollection #389

m-mohr opened this issue Oct 9, 2022 · 3 comments · Fixed by #395 or #382
Labels
breaking help wanted Extra attention is needed vector
Milestone
2.0.0

Comments

@m-mohr
Copy link
Member

m-mohr commented Oct 9, 2022

We are working towards v2 of the processes for vector cubes. I think this is a good chance to disallow and remove the already "not recommended" GeometryCollection from the processes.

Thoughts?
@m-mohr m-mohr added help wanted Extra attention is needed breaking labels Oct 9, 2022
@m-mohr m-mohr added this to the 2.0.0 milestone Oct 9, 2022
@soxofaan
Copy link
Member

Getting rid of GeometryCollection as an allowed geometry type simplifies things for backend implementors, so that's good.
I have no idea if it is a valuable type for real use cases and end users.

Related: Open-EO/openeo-python-driver#71 (in VITO backend we handle a GeometryCollection as a feature collection, and we want to get rid of that inconsistency)

m-mohr added a commit that referenced this issue Nov 28, 2022
@m-mohr
Deprecated GeometryCollections are not supported any longer. #389
2a1e65b
@m-mohr m-mohr mentioned this issue Nov 28, 2022
Merged
@m-mohr m-mohr linked a pull request Nov 28, 2022 that will close this issue
Deprecated GeometryCollections are not supported any longer. #389 #395
Merged
@m-mohr
Copy link
Member Author

m-mohr commented Nov 28, 2022 •
edited
Loading

PR #395 proposes to remove GeometryCollection. It has been deprecated in 1.1.0 and as such is a good candidate for removal in 2.0.0.

@soxofaan
Copy link
Member

PR #289 proposes to ...

I guess you meant PR #395 ?

m-mohr added a commit that referenced this issue Jan 18, 2023
@m-mohr
Deprecated GeometryCollections are not supported any longer. #389 (#…
9260dfd 
…395)
@m-mohr m-mohr linked a pull request Jan 18, 2023 that will close this issue
Migrate to general data cube definition #382
Merged
14 tasks
@m-mohr m-mohr added the vector label Jan 30, 2023
@m-mohr m-mohr closed this as completed Jan 30, 2023
This was referenced May 4, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking help wanted Extra attention is needed vector
Projects
None yet
Milestone
2.0.0
2 participants
@soxofaan @m-mohr