-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define aggregate_bbox
method
#203
Comments
alternative: also accept a bbox dict in |
Note: this would be a client side convenience feature and not allow UDP parameterization (because graph will still contain |
I would go for using aggregate_spatial with the bbox dict, to avoid confusion with another process. |
While it pretty easy to do either of the proposed solutions in the client, we also have use cases with UDPs which could benefit from this feature. But because of the UDPs, this handling must be done at backend-side. @m-mohr do you think it is useful to expand |
Spontaneously: For a single bbox it's probably easier to use filter_bbox and then do a reduce_dimension, right? |
yes, but we do not support reduce_dimension over over two dimensions ( |
Yes, this issue is a blocker again... If I'm remembering correctly we had a similar issue some weeks ago. Maybe we generally need to figure out a way to work on a (combined) "spatial" dimension. Need to find the other issue again.... |
I think I wouldn't add the bbox subtype to aggregate_spatial but instead try to find a solution for Open-EO/openeo-processes#226 - We need to find a common solution anyway and then filter_bbox is good enough. |
agreed, that's probably not the cleanest approach another possible solution: add a process that converts a bounding box object to a geojson polygon, e.g. |
For now, such a method can simply be implemented on the client-side, right? |
yeah sure, that was the original idea of this ticket. And quite trivial to implement indeed. But the next step is also solve if for UDPs, for example where there is a single |
For a UDP that also uses aggregate_spatial in the UDP, I'd use filter_spatial instead of filter_bbox. This way you can ask for a GeoJSON as an input parameter of the UDP and then let the client convert it to GeoJSON from a given bbox. |
filter_bbox
expects a simple west/south/east/north dictionaryaggregate_spatial
expects a shapely geometry or geojson format dict, which is less straightforward to build if you just have west/south/east/north bounds.It could be useful for simple use cases to also provide
aggregate_bbox
to aggregate spatially, given a simple west/south/east/north dictThe text was updated successfully, but these errors were encountered: