Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version and provider hardcoded #60

Open
clausmichele opened this issue Jul 26, 2022 · 2 comments
Open

version and provider hardcoded #60

clausmichele opened this issue Jul 26, 2022 · 2 comments
Assignees

Comments

@clausmichele
Copy link
Member

clausmichele commented Jul 26, 2022

Currently in the exposed metadata the version is hardcoded here:

and the provider has a default value here:

I propose to remove the default hardcoded version and retrieve it from Rasdaman or ODC.

For the provider instead, we should firstly check if there is one available and if not, set the default one.
Additionally, it seems that maximum 4 providers are allowed.

@aljacob what do you think about this limitation? Should we allow more than 4?

@pierocampa I tag you here just for your interest.

@clausmichele clausmichele self-assigned this Jul 26, 2022
@clausmichele clausmichele changed the title version and providers hardcoded version and provider hardcoded Jul 26, 2022
@pierocampa
Copy link
Member

pierocampa commented Jul 26, 2022

The version should keep the version of the collection, when specified.

The "Eurac EO WCS" "host (not the provider) should really be factored out to a configuration file.
The provider, which is indeed better taken from the collection's metadata, is however not overwritten now by the server, so no need to act imho. Just the host' is.


As a final note: this ticket exposes a code duplication in the CollectionsApiController class, see describeCollection() and loadWcpsCollections() methods.

@pierocampa
Copy link
Member

I also understand that having a version, requires to add a stac_extension:

This property REQUIRES to add version (STAC < 1.0.0-rc.1) or https://stac-extensions.github.io/version/v1.0.0/schema.json (STAC >= 1.0.0-rc.1) to the list of stac_extensions.

I would propose to keep this "v1" as default value in case an input collection does not specify a version, while not overwriting existing versioning. This means that stac_extensions will have to include version (as the currently implemented STAC version is 0.9.0 afaik).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants