Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18/10/2022]: TASK 3 - Add Event SubPages and Its Arabic Equivalent #190

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[18/10/2022]: TASK 3 - Add Event SubPages and Its Arabic Equivalent #190

wants to merge 5 commits into from

Conversation

okerekechinweotito
Copy link

@okerekechinweotito okerekechinweotito commented Oct 18, 2022 •
edited
Loading

Summary

Fixes #188

I added 3 Event cards and a corresponding event subpage for each card showing description of the event, speaker, language and a link to the slides from Zenodo.

List of changes proposed in this PR (pull-request)

  • Added Events item on the NavBar
  • Added 3 Events Card with link to subpages
  • Created an Event Section on the homePage
  • Added 3 Events subpage with details of the events
  • Added an Arabic Page for each subpage made
  • Created a dedicated Events page to enable multiple events to be added in the future ( this would help to declutter the homePage)
  • Updated the Arabic Homepage (ar.index.html) to reflect the new changes made to the English Homepage(index.html)

What should a reviewer concentrate their feedback on?

✅ Review the Events section on the Homepage
✅ Review the dedicated Events Page
✅ Review the 3 Events cards and their subpages
✅ Review the Arabic pages

Events Card
Screenshot (52)

Events Subpage
Screenshot (55)

Events Subpage
Screenshot (56)

@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited
Loading

✅ Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit a446e35
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/6355bff8421ccb000806fd98
😎 Deploy Preview https://deploy-preview-190--oscksa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced Oct 18, 2022
Open
Open
@okerekechinweotito
Copy link
Author

okerekechinweotito commented Oct 18, 2022 •
edited
Loading

@BatoolMM @alswajiab I combined Tasks 3.1 , 3.2 and 3.3 because they are part of same user flow. I could separate them into individual PRs if need be. Please Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[18/10/2022]: TASK 3 - Add Event SubPages
1 participant
@okerekechinweotito