[30-10-2022]Accessibility Improvement #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oscksa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thank you @adetyaz for the wonderful PR to improve accessibility. Can you fix the image links - they aren't working anymore! |
|
@BatoolMM No problem, I'll take a look at them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran the current website on https://wave.webaim.org/ to evaluate the accessibility and some suggestions were made of sections that need to be improved
Fixes #220
List of changes proposed in this PR (pull-request)
Improves accessibility by
[x] Adding alt text to the logo
[x] Improve empty links by adding a screen reader only element to improve website experience
What should a reviewer concentrate their feedback on?