Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The version manager does not respect the NO_PROXY environment variable. #652

Open
adnbrownie opened this issue Jun 20, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@adnbrownie
Copy link
Contributor

🐛 Bug Report:

Describe the bug

The version manager does not respect the NO_PROXY environment variable. When using the openapi-generator-cli behind a corporate proxy (i.e. HTTP_PROXY & HTTPS_PROXY are set) while trying to download a version of openapi generator from a private maven repository (which is within the corporate network, i.e. the download should not go through the proxy), the NO_PROXY environment variable is ignored.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Use the openapi-generator-cli version manager to download a version from a private repository within a corporate network, which is separated from the internet by a proxy.
  2. openapi-generator-cli respects HTTP_PROXY & HTTPS_PROXY (which are needed for requests from within the corporate network to the internet, but fails to download from the internal maven repo, as it still tries to go through the proxy:
> openapi-generator-cli generate

Download 6.0.0 ...
Download failed, because of: "socket hang up"
  1. Only by explicitly un-setting the HTTP_PROXY & HTTPS_PROXY environment variables as a work-around it is possible to download from the private repo.

Expected behavior

The openapi-generator-cli version manager should respect the NO_PROXY environment variable and download the version of openapi generator from the private repo without going through the proxy.

Additional context

Also mentioned in these comments.

@adnbrownie adnbrownie added the bug Something isn't working label Jun 20, 2022
@adnbrownie adnbrownie changed the title [BUG] [BUG] The version manager does not respect the NO_PROXY environment variable. Jun 22, 2022
@adnbrownie
Copy link
Contributor Author

As it seems, this would be fixed with PR 651.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants