Skip to content

[BUG] Duplicate models are produced when a file is referenced multiple times by different paths #18948

Open
@ctreatma

Description

@ctreatma

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

A recent openapi-generator release upgraded swagger-parser to 2.1.22. That upgrade resolved a bug where the parser was unable to resolve relative refs to real file paths, but it introduced a new bug where the parser creates duplicate schema objects for each unique relative path, rather than reusing an existing schema when two (or more) relative paths are equivalent.

openapi-generator version

v7.5.0

OpenAPI declaration file content or url

Refer to swagger-api/swagger-parser#2105 for a reproduction OpenAPI spec.

Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix

I don't think there's a way to work around this issue in openapi-generator itself; instead it requires a fix in swagger-parser that is then pulled in to this project in a future parser upgrade.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions