Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][dart-dio] Avoid depending on Equatable implementation files #20158

Open
5 tasks done
LukasMirbt opened this issue Nov 21, 2024 · 0 comments
Open
5 tasks done

[BUG][dart-dio] Avoid depending on Equatable implementation files #20158

LukasMirbt opened this issue Nov 21, 2024 · 0 comments

Comments

@LukasMirbt
Copy link

LukasMirbt commented Nov 21, 2024

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

With equalityCheckMethod: equatable, an implementation file (package:equatable/src/equatable_utils.dart) is imported and the internal equals and mapPropsToHashCode functions are used.

equals was recently removed in Equatable v2.0.6 and then reverted in v2.0.7.

Suggest a fix

Would it be possible to use Equatable through the public interface instead of depending on internal code that may break again in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant