Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My attempt to improve RotatePointAroundVector and VectorNormalize functions in q_math.c #45

Open
suijingfeng opened this issue May 5, 2018 · 0 comments
Open

My attempt to improve RotatePointAroundVector and VectorNormalize functions in q_math.c #45

suijingfeng opened this issue May 5, 2018 · 0 comments

Comments

@suijingfeng
Copy link

suijingfeng commented May 5, 2018 •
edited
Loading

  1. if the direction Vector given isn't normalized, function PointRotateAroundVector get wrongs results.
  2. Apparently, PointRotateAroundVector function need more computions than PointRotateAroundVector I write.
  3. Q_rsqrt , Q_fabs not necessarily faster than 1.0f /sqrtf() and fabs() that std c lib provide.

https://gist.github.com/suijingfeng/92e510aafe0e0246b3b4648c2c5eac21
@suijingfeng suijingfeng changed the title My attempt to improve PointRotateAroundVector and Q_fabs functions in q_math.c My attempt to improve RotatePointAroundVector and Q_fabs functions in q_math.c May 6, 2018
@suijingfeng suijingfeng changed the title My attempt to improve RotatePointAroundVector and Q_fabs functions in q_math.c My attempt to improve RotatePointAroundVector and VectorNormalize functions in q_math.c May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suijingfeng