[Post-0.8.8 bug] Invisible Lightning from LG #316
Comments
NeonKnightOA
added
bug
|
Do gou mean that now your own lightning gun beam is invisible? In all circumstances? |
This comment was marked as abuse.
This comment was marked as abuse.
|
"SP" as Single Player deatchmatch (gametype 2)? Or any gametype? Unfortunately, I haven't touched the LG in my tests this morning, and I will not be able to test for a few days. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Are the steps to reproduce just "load a map containing lightning gun and start shooting"? Note: with that nightly build there is still a problem -maybe you fixed yesterday- with starting SP from the GUI (no bots were added, a warning about "Ayu" not being found was shown in console), so I did load oa_rpg3dm2 manually and then set g_gametype 2 and restarted. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
|
Looking at some reports on Discord by erdem an cappucciNo, it looks like it's a Linux-only issue, probably due to a newer version of glibc (they reported with Fedora 39 and Manjaro Linux). |
|
It looks like there might be two different issues resulting in invisible lightning gun, as:
|
Several people have noticed a curious regression which cause some secondary weapon models (such as machinegun's barrel) to not be rendered. For instance: - OpenArena#316 - OpenArena/engine#85 - https://forum.manjaro.org/t/openarena-lightning-gun-beam-not-visible-with-glibc-2-37-x86-64-bug/135312 And some people have hypothesized that this could have something to do with a recent change in glibc. I'm also facing this issue since an upgrade from ubuntu 22.04 to 24.04 and I've found its cause, here is the patch. As you can see the logic to add a suffix to the primary weapon model was previously based on a call to COM_StripExtension() with the same pointer for in & out. However, this function passes in & out to Q_strncpyz() which itself relies on strncpy() which does not specify the expected behavior in case of aliasing/overlapping of src & dst. So it was relying on an unspecified behavior, prone to change at any time and without any communication. This patch passes the build step but I've tested it in-game with the legacy project https://github.com/OpenArena/legacy and a back-ported version of it.
|
Does the merge above fix the problem or do some aspects of the bug still remain? |
|
No, it only fixes the behavior described bellow, which is in the end not related to the current issue.
The LG is not impacted by the bug I've fixed. |
|
@oitzujoey I confused the LG with the RG, and the LG is actually impacted by the bug I've fixed. |
One day, doing a run on the SP, I noticed that the Lightning Gun wasn't shooting anything but the ammo count still lowered and the marks on the walls and floors still kept being displayed.
I tested the last 2023 nightly and it still showed up.
I tested the very first nightly, it still showed up.
I tested with b52 and it still showed up.
I tested 0.8.8 and the LG behaved as normal.
So the bug may have been introduced between version 0.8.8 and one of the post-0.8.8 releases. Or perhaps it's a problem with my old config. I reset the config and the bug was gone. Still it's not a scenario that should be reproduced.
The text was updated successfully, but these errors were encountered: