Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Webhook to add closed-by-bot label #110

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Member

@pllim pllim commented Aug 7, 2019

Fix OpenAstronomy/baldrick#81

TODO

  • Figure out the right incantation to grab "closed by who" login ID
  • Add tests

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #110 into master will decrease coverage by 0.46%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   99.09%   98.63%   -0.47%     
==========================================
  Files           5        7       +2     
  Lines         221      293      +72     
==========================================
+ Hits          219      289      +70     
- Misses          2        4       +2
Impacted Files Coverage Δ
astropy_bot/closedbybotlabel.py 94.11% <94.11%> (ø)
astropy_bot/tests/test_closedbybotlabel.py 98.18% <98.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f075eac...f42203c. Read the comment docs.

@pllim pllim changed the title WIP: Webhook to add closed-by-bot label Webhook to add closed-by-bot label Aug 8, 2019
@pllim pllim requested review from astrofrog and bsipocz August 8, 2019 18:57
@pllim
Copy link
Member Author

pllim commented Aug 8, 2019

Theoretically, this should work but can't be sure until it is live.

And maybe this is moot with GitHub Actions anyway, but until we can get our hands on the beta... 🤷‍♀️

@bsipocz
Copy link
Member

bsipocz commented Aug 8, 2019

And maybe this is moot with GitHub Actions anyway, but until we can get our hands on the beta...

I seem to have it, but then it's useless without having repos 😅

@pllim
Copy link
Member Author

pllim commented Aug 12, 2019

Oh... it labels itself now. Maybe @astrofrog fixed the permission. I should just close this then.

astropy/astropy#6065 (comment)

@pllim pllim closed this Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bot to auto add closed-by-bot label when bot close stale issue/PR
2 participants