Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin breaks on having the package name in the package deps #30

Open
Cadair opened this issue Mar 13, 2024 · 2 comments
Open

Plugin breaks on having the package name in the package deps #30

Cadair opened this issue Mar 13, 2024 · 2 comments

Comments

@Cadair
Copy link
Member

Cadair commented Mar 13, 2024

Since we moved to pyproject.toml with sunpy we have had this style of dependancies to reduce duplication in our dep lists:

all = ["sunpy[asdf,dask,image,jpeg2000,map,net,timeseries,visualization]"]
tests = [
  "sunpy[all,opencv,spice]",

https://github.com/sunpy/sunpy/blob/7d3cc09fed175db7f8e384433a4c7a27295b6797/pyproject.toml#L89-L91

This as it is at the moment fails because we haven't got a minimum version there, but we also don't want to put the name of the package in the generated requirement output at all.

@braingram
Copy link

braingram commented Mar 18, 2024

I'm curious to see if the following works (and to hear your opinions on uv). Would you try the following (in the sunpy repo checkout)?

uv pip compile --resolution=lowest-direct --extra all pyproject.toml

@Cadair
Copy link
Member Author

Cadair commented Apr 17, 2024

I am sure that would work, but I haven't tried to uv yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants