Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto Inject Form - Part 2 #2172

Open
MarineLeM opened this issue Jan 8, 2025 · 1 comment
Open

Refacto Inject Form - Part 2 #2172

MarineLeM opened this issue Jan 8, 2025 · 1 comment
Assignees
@MarineLeM
Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Milestone
Bugs backlog

Comments

@MarineLeM
Copy link
Contributor

MarineLeM commented Jan 8, 2025 •
edited
Loading

Description

This issue is part of the ongoing Inject Form refactoring effort.

Part 1 :
issue : #2038
PR : #2042

Context :

Currently, the UpdateInjectDetails.js and CreateInjectDetails.js files contain approximately 90% duplicated code, leading to redundancy and maintenance challenges.

Tasks :

  • Refactor the common logic and components from CreateInjectDetails.js and UpdateInjectDetails.js into a single TSX file.
  • Ensure the new component supports the functionality required for both creation and update flows.
@MarineLeM MarineLeM added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jan 8, 2025
@MarineLeM MarineLeM self-assigned this Jan 8, 2025
@EllynBsc
Copy link
Member

EllynBsc commented Jan 8, 2025

Hi @MarineLeM 👋

Can you mention the ongoing Inject Form refactoring effort PR here ? Thank you!

@EllynBsc EllynBsc added technical improvement Technical refactor or improvement is needed and removed needs triage use to identify issue needing triage from Filigran Product team labels Jan 8, 2025
@EllynBsc EllynBsc added this to the Bugs backlog milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarineLeM MarineLeM

Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Projects
None yet
Milestone
Bugs backlog
Development

No branches or pull requests
2 participants
@MarineLeM @EllynBsc