Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve injector contract content fetching #2452

Open
MarineLeM opened this issue Feb 14, 2025 · 0 comments
Open

Improve injector contract content fetching #2452

MarineLeM opened this issue Feb 14, 2025 · 0 comments
Labels
feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed

Comments

@MarineLeM
Copy link
Contributor

Description

In the application, there are two different behaviors when fetching the inject contract content:

  1. Fetching inject contract content as a string
  • The backend returns the inject contract content as a string, which is then parsed on the frontend.
  • Example API endpoint: /api/injector_contracts/search (used when fetching all inject contracts for creating an atomic test).
    request answer :

Image

  1. Fetching inject contract content as both a string and a converted JSON property
  • The backend provides the inject contract content in two different formats
  • Example API endpoint: api/injects/{injectId}
    request answer :
    Image

Proposed Solution :

The inject contract content should always be returned as a JSON object, avoiding string parsing.

A possible improvement is to declare it as ContractContent in the backend instead of using ObjectNode, ensuring a clear and structured API response.

@MarineLeM MarineLeM added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team technical improvement Technical refactor or improvement is needed labels Feb 14, 2025
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Feb 14, 2025
@EllynBsc EllynBsc added this to the Bugs backlog milestone Feb 14, 2025
@EllynBsc EllynBsc added feature use for describing a new feature to develop and removed bug use for describing something not working as expected labels Feb 14, 2025
@EllynBsc EllynBsc removed this from the Bugs backlog milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

No branches or pull requests

2 participants