From a1cbfbe1d838eb0e1aa708022bed3f78518f2d6a Mon Sep 17 00:00:00 2001 From: Hongwei Date: Mon, 18 Dec 2023 10:34:24 +0100 Subject: [PATCH 1/2] bugfix/sonarcloud Introduce a new variable or use its initial value before reassigning --- apimanager/metrics/views.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/apimanager/metrics/views.py b/apimanager/metrics/views.py index d8413846..e75d8cf2 100644 --- a/apimanager/metrics/views.py +++ b/apimanager/metrics/views.py @@ -320,21 +320,17 @@ def get_aggregate_metrics(self, from_date, to_date, include_app_names): only_show_api_explorer_metrics has the default value False, because it is just used for app = API_Explorer. """ try: - api_calls_total = 0 - average_response_time = 0 url_path = '/management/aggregate-metrics?from_date={}&to_date={}&include_app_names={}'.format(from_date, to_date, self.get_app_name_parameters(include_app_names)) api = API(self.request.session.get('obp')) metrics = api.get(url_path) - api_calls_total, average_calls_per_day, average_response_time = self.get_internal_api_call_metrics( - api_calls_total, average_response_time, from_date, metrics, to_date, url_path) + api_calls_total, average_calls_per_day, average_response_time = self.get_internal_api_call_metrics(from_date, metrics, to_date) return api_calls_total, average_response_time, int(average_calls_per_day) except APIError as err: error_once_only(self.request, err) except Exception as err: error_once_only(self.request, err) - def get_internal_api_call_metrics(self, api_calls_total, average_response_time, from_date, metrics, - to_date, urlpath): + def get_internal_api_call_metrics(self,from_date, metrics,to_date): api_calls_total = metrics[0]["count"] average_response_time = metrics[0]["average_response_time"] to_date = datetime.datetime.strptime(to_date, API_DATE_FORMAT_WITH_MILLISECONDS) From 825495b9a87482105c233abb879342c668d23533 Mon Sep 17 00:00:00 2001 From: Hongwei Date: Wed, 14 Feb 2024 14:51:13 +0100 Subject: [PATCH 2/2] bugfix/fixed the bug for consumer_id --- apimanager/metrics/forms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apimanager/metrics/forms.py b/apimanager/metrics/forms.py index 36692785..ff2d5c26 100644 --- a/apimanager/metrics/forms.py +++ b/apimanager/metrics/forms.py @@ -75,7 +75,7 @@ class APIMetricsForm(MetricsForm): ('PUT', 'PUT'), ) - consumer_id = forms.ChoiceField( + consumer_id = forms.CharField( label=_('Consumer ID'), widget=forms.TextInput( attrs={