From 29664abed816c1ebc70608c37fa57041d7f3dfb4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20Mili=C4=87?= Date: Mon, 15 Apr 2024 14:29:09 +0200 Subject: [PATCH 1/4] docfix/Add CRL item to the Glossary --- obp-api/src/main/scala/code/api/util/Glossary.scala | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/obp-api/src/main/scala/code/api/util/Glossary.scala b/obp-api/src/main/scala/code/api/util/Glossary.scala index 3ff011a8cf..96fe695ae6 100644 --- a/obp-api/src/main/scala/code/api/util/Glossary.scala +++ b/obp-api/src/main/scala/code/api/util/Glossary.scala @@ -3192,6 +3192,14 @@ object Glossary extends MdcLoggable { |as well as the authenticity and integrity of the sealed data, and also prove it to third parties. |The electronic seal provides strong evidence, capable of having legal effect, that given data is originated by the legal entity identified in the certificate.""".stripMargin) + glossaryItems += GlossaryItem( + title = "CRL", + description = + s"""Certificate Revocation List. + |CRL issuers issue CRLs. The CRL issuer is either the CA (certification authority) or an entity that has been authorized by the CA to issue CRLs. + |CAs publish CRLs to provide status information about the certificates they issued. + |However, a CA may delegate this responsibility to another trusted authority.""".stripMargin) + glossaryItems += GlossaryItem( title = "Cross-Device Authorization", description = From fd6705de2ea4c3bd8ebd9f890c151019e771ab7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20Mili=C4=87?= Date: Mon, 15 Apr 2024 14:38:14 +0200 Subject: [PATCH 2/4] docfix/Add OCSP item to the Glossary --- obp-api/src/main/scala/code/api/util/Glossary.scala | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/obp-api/src/main/scala/code/api/util/Glossary.scala b/obp-api/src/main/scala/code/api/util/Glossary.scala index 96fe695ae6..b55f061c9a 100644 --- a/obp-api/src/main/scala/code/api/util/Glossary.scala +++ b/obp-api/src/main/scala/code/api/util/Glossary.scala @@ -3198,7 +3198,14 @@ object Glossary extends MdcLoggable { s"""Certificate Revocation List. |CRL issuers issue CRLs. The CRL issuer is either the CA (certification authority) or an entity that has been authorized by the CA to issue CRLs. |CAs publish CRLs to provide status information about the certificates they issued. - |However, a CA may delegate this responsibility to another trusted authority.""".stripMargin) + |However, a CA may delegate this responsibility to another trusted authority. + |It is described in RFC 5280.""".stripMargin) + + glossaryItems += GlossaryItem( + title = "OCSP", + description = + s"""The Online Certificate Status Protocol (OCSP) is an Internet protocol used for obtaining the revocation status of an X.509 digital certificate. + |It is described in RFC 6960 and is on the Internet standards track. It was created as an alternative to certificate revocation lists (CRL),""".stripMargin) glossaryItems += GlossaryItem( title = "Cross-Device Authorization", From ae537b578b5b0c3e9093c83c1e29a9c23e70e0ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20Mili=C4=87?= Date: Thu, 18 Apr 2024 13:08:43 +0200 Subject: [PATCH 3/4] docfix/Tweak error message at grantAccessToMultipleViews function --- obp-api/src/main/scala/code/model/BankingData.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/obp-api/src/main/scala/code/model/BankingData.scala b/obp-api/src/main/scala/code/model/BankingData.scala index feb2985c98..086d1692cb 100644 --- a/obp-api/src/main/scala/code/model/BankingData.scala +++ b/obp-api/src/main/scala/code/model/BankingData.scala @@ -250,7 +250,7 @@ case class BankAccountExtended(val bankAccount: BankAccount) extends MdcLoggable grantedViews <- Views.views.vend.grantAccessToMultipleViews(viewUIDs, otherUser, callContext) ?~ "could not save the privilege" } yield grantedViews else - Failure(UserLacksPermissionCanGrantAccessToViewForTargetAccount + s"Current ViewIds${viewUIDs.map(_.viewId.value)} and current UserId${user.userId}") + Failure(UserLacksPermissionCanGrantAccessToViewForTargetAccount + s"Current ViewIds${viewUIDs.map(_.viewId.value).mkString(", ")} and current UserId${user.userId}") } /** From c25a4ec2c470b90021d2fe1664226fb99ffbf4cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20Mili=C4=87?= Date: Thu, 18 Apr 2024 15:36:36 +0200 Subject: [PATCH 4/4] feature/Improve application access text --- .../src/main/scala/code/snippet/ConsentScreen.scala | 3 --- obp-api/src/main/webapp/consent-screen.html | 10 ++-------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/obp-api/src/main/scala/code/snippet/ConsentScreen.scala b/obp-api/src/main/scala/code/snippet/ConsentScreen.scala index f04a543a6e..841140d864 100644 --- a/obp-api/src/main/scala/code/snippet/ConsentScreen.scala +++ b/obp-api/src/main/scala/code/snippet/ConsentScreen.scala @@ -77,10 +77,7 @@ class ConsentScreen extends MdcLoggable { val username = AuthUser.getCurrentUser.map(_.name).getOrElse("") val oidcProviderDescription = getWebUiPropsValue("webui_hydra_oidc_client", "OpenID Connect Provider") "#username *" #> username & - "#username_2 *" #> username & "#consumer_description_1 *" #> oidcProviderDescription & - "#consumer_description_2 *" #> oidcProviderDescription & - "#consumer_description_3 *" #> oidcProviderDescription & "form" #> { "#skip_consent_screen_checkbox" #> SHtml.checkbox(skipConsentScreenVar, skipConsentScreenVar(_)) & "#allow_access_to_consent" #> SHtml.submit(s"Allow access", () => submitAllowAction) & diff --git a/obp-api/src/main/webapp/consent-screen.html b/obp-api/src/main/webapp/consent-screen.html index 489b05afba..d7f7da7dea 100644 --- a/obp-api/src/main/webapp/consent-screen.html +++ b/obp-api/src/main/webapp/consent-screen.html @@ -34,14 +34,8 @@ }
-

An application requests access to your data!

-

Hi , application wants access resources on your behalf and to:

-
    -
  • openid
    • -
-

Confirm or Deny Applicaiton Access.

-

Dear , is requesting access to your user profile.

-

will be able to act on your behalf.

+

Confirm Application Access

+

Hi , the wants to act on your behalf.