Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install/uninstall adjustements #1

Open
teknowledgist opened this issue Dec 13, 2021 · 3 comments
Open

Install/uninstall adjustements #1

teknowledgist opened this issue Dec 13, 2021 · 3 comments

Comments

@teknowledgist
Copy link
Collaborator

Hi. Thanks for working on automating this! I have a couple questions...

  1. You say you are using GitHub actions to populate the version string (and the hash, I assume). Will you also be pushing the packed package file up to the community repository?
  2. The current install will generate a new Start Menu icon for every version (with the version number in the shortcut name), but not remove the older ones. The older icons will work since each new version gets a new "install" directory based on the version number too. Since I am not an OpenChrom user, I'm not sure of the "best" install option. Should previous versions be removed on "install" of a new version? Should the binaries remain, but the Start Menu shortcut be deleted? Should the Start menu shortcut name not contain the version number and always point to the latest unzipped version?
  3. The current uninstall will (kinda') delete all the installations, but there is room for improvement. In particular, I'm not sure what I was thinking with the long-path fix. I don't think it will work that way, but I should be able to "fix" it. I guess I don't have a third question, more of a admission of bad code. 😄

Thanks.

@teknowledgist
Copy link
Collaborator Author

  1. More specific version download? openchrom#99 (comment) 😄
  2. I'm happy to make the package work as you envision users working with OpenChrom, but you'll have to define that. Specifically:
    a. Replace old installs with new?
    b. Is it OK to have a "OpenChrom" Start Menu icon instead of "OpenChrom v##"?
  3. I'll fix the uninstaller when I know what is happening with (2).

thanks.

@Mailaender
Copy link
Member

I think we want to replace old installs with new ones. At least that is what I expect Chocolatey to do for me. If I want to test the new version and keep the previous, I would probably do it manually. It could also lead to confusion. As the difference is just a date and time squashed together behind a mostly static version number, you can't easily tell if you clicked on the latest release.

The long paths are a known problem. We recommend using 7-Zip to extract and I saw in the VM that this is exactly what Chocolatey already does. I saw the workaround for the folder deletion and didn't have a better idea if rmdir /S /Q doesn't work.

@Mailaender
Copy link
Member

https://www.openchrom.net/download now also features an NSIS installer which includes a long path fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants