Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust code font #209

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adjust code font #209

wants to merge 4 commits into from

Conversation

behoppe
Copy link
Member

@behoppe behoppe commented Mar 30, 2023

No description provided.

@netlify
Copy link

netlify bot commented Mar 30, 2023 •
edited
Loading

✅ Deploy Preview for sage-licorice-6da44d ready!

Name Link
🔨 Latest commit 79c4ecb
🔍 Latest deploy log https://app.netlify.com/sites/sage-licorice-6da44d/deploys/6425cf304a2d230009eff7dd
😎 Deploy Preview https://deploy-preview-209--sage-licorice-6da44d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@behoppe behoppe changed the title tweak header Adjust code font Mar 30, 2023
@behoppe behoppe linked an issue Mar 30, 2023 that may be closed by this pull request
Fix outstanding problems with the new pydata-sphinx theme #203
Open
@behoppe
Copy link
Member Author

behoppe commented Mar 30, 2023

@neboat I have fixed the code font size on every OS/broswer config I have tested (including Windows, Ubuntu, Apple iPhone and iPad with Firefox, Chrome, and Safari). Could you please confirm that it's fixed for you too? Thank you.
Screenshot 2023-03-30 at 14-12-49 Cilkscale — scalability analysis benchmarking tool

@behoppe behoppe requested a review from neboat March 30, 2023 18:18
@neboat
Copy link
Contributor

neboat commented Mar 30, 2023

Hey @behoppe. At the moment I can only check this page on my laptop running macOS. But that was the system giving me trouble before, and I can confirm that the font sizes look good on that system with this change. Thanks for working on this!

I can take a look at the page on another system this evening, if you want.

@behoppe
Copy link
Member Author

behoppe commented Mar 30, 2023

Thanks @neboat. Sure, please try one more test and let me know how that goes. Thank you.

neboat
neboat approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@neboat neboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the preview on macOS using Chrome and Safari, on Windows using Chrome and Edge, and on Android. From browsing a few pages with code, the new code font looks good on those devices and browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neboat neboat neboat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix outstanding problems with the new pydata-sphinx theme
2 participants
@behoppe @neboat