Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with oc_addons *not* ignoring a second collar #1038

Open
Pingout opened this issue Apr 24, 2024 · 2 comments
Open

Problem with oc_addons *not* ignoring a second collar #1038

Pingout opened this issue Apr 24, 2024 · 2 comments
Labels
Needs testing This issue needs volunteers to try to duplicate the error or identify a caues

Comments

@Pingout
Copy link
Collaborator

Pingout commented Apr 24, 2024

What version of OpenCollar are you using? OC 8.2.3

What behavior did you expect?

What behavior did you see instead? As a collar designer wearing a collar, if you rez a collar to work on it, the oc_addon script will try to connect the rezzed collar as an addon. The message you receive as Collar Wearer is: [19:44] Collar for Prototype Set: Addon connected successfully: OpenCollar

What steps does someone need to take to reproduce the problem? Wear a collar, then rez a second collar nearby

Pingout added a commit that referenced this issue Apr 24, 2024
Reference Issue #1038
@Pingout Pingout added the Needs testing This issue needs volunteers to try to duplicate the error or identify a caues label Apr 25, 2024
@Trix7125
Copy link
Contributor

thumbs up

[04:00:24] Test Collar #1038: Collar is preparing to start up, please be patient.
[04:00:35] Test Collar #1038: Startup in progress... be patient
[04:00:39] Test Collar #1038: RLV active!
[04:00:48] Test Collar #1038: Collar ready. Startup complete
[04:01:33] Test Collar #1038: Collar is preparing to start up, please be patient.
[04:01:43] Test Collar #1038: Startup in progress... be patient
[04:01:46] Test Collar #1038: RLV active!
[04:01:56] Test Collar #1038: Collar ready. Startup complete
[04:03:00] Test Collar #1038: Addon connected successfully: Lower Left Arm Cuff
[04:03:00] Test Collar #1038: Addon connected successfully: Lower Left Arm Cuff
[04:03:00] O Collar: Addon connected successfully: Lower Left Arm Cuff
[04:03:00] Test Collar #1038: Addon connected successfully: Left Lower Leg Cuff
[04:03:00] O Collar: Addon connected successfully: Left Lower Leg Cuff
[04:03:00] Test Collar #1038: Addon connected successfully: Left Lower Leg Cuff
[04:03:05] Test Collar #1038: Addon connected successfully: Leg Chains
[04:03:05] O Collar: Addon connected successfully: Leg Chains
[04:03:05] Test Collar #1038: Addon connected successfully: Leg Chains
[04:03:18] Test Collar #1038: Addon connected successfully: Arm Chains
[04:03:18] O Collar: Addon connected successfully: Arm Chains
[04:03:18] Test Collar #1038: Addon connected successfully: Arm Chains
[04:05:53] Test Collar #1038: Collar is preparing to start up, please be patient.
[04:06:03] Test Collar #1038: Startup in progress... be patient
[04:06:07] Test Collar #1038: RLV active!
[04:06:17] Test Collar #1038: Collar ready. Startup complete

@tayaphidoux
Copy link
Contributor

tayaphidoux commented Jun 22, 2024

my mini con project actualy thought of this issue its one of the things i had meintioned a long time ago that was a potential issue, security hole solution is to store the key of the collar after successfull connection and ignore all calls from any thing else, then you have to have a way to detect when the collar id changes on relog, a solution i have not done yet would be to have the collar and app to store a shared secret and use that when restablishing connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs testing This issue needs volunteers to try to duplicate the error or identify a caues
Projects
None yet
Development

No branches or pull requests

3 participants