Dead code: !pong handler in oc_rlvsys ? Updated

[NikkiLacrima]

What version of OpenCollar are you using? 8.3

On line 628 of oc_rlvsys:

            } else if (iNum == CMD_RLV_RELAY) {
                if (llGetSubString(sStr,-43,-1)== ","+(string)g_kWearer+",!pong") { //if it is a pong aimed at wearer
                    //Debug("Received pong:"+sStr+" from "+(string)kID);
                    if (kID==g_kSitter) llOwnerSay("@"+"sit:"+(string)g_kSitTarget+"=force");  //if we stored a sitter, sit on it
                    rebakeSourceRestrictions(kID);
                }

This seems to be dead code.
The link message CMD_RLV_RELAY is never sent, replaced by CMD_RLV, so this code is never invoked.
There is also a !pong handler in oc_relay::Process().

[NikkiLacrima]

... update ... More digging into the handling of reattaching and ping/pong stuff leads to the conclusion that we should move all of this from relay to rlvsys that does already handle list of restrictions from several sources. This can hopefully make the collar relay handle several simultaneous restriction sources. Test implementation is worked on ...

[SilkieSabra]

Has this one been worked on for 8.3?

[NikkiLacrima]

I have test code that makes the collar handle several sources of RLV commands, both internal and external. So far seems quite stable, not ready for PR but it is being worked on, perhaps 8.4.

See discussion #1094.