Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc_label and oc_meshlabel conflict #1122

Open
Pyhrn opened this issue Dec 28, 2024 · 2 comments
Open

oc_label and oc_meshlabel conflict #1122

Pyhrn opened this issue Dec 28, 2024 · 2 comments
Labels

Comments

@Pyhrn
Copy link

Pyhrn commented Dec 28, 2024

What version of OpenCollar are you using?
Any version to update 8.3.0000

What behavior did you expect?
Label feature should work as before the update

What behavior did you see instead?
I got two popups instead of one when calling the Label app from the app menu, blocking each other out

What steps does someone need to take to reproduce the problem?
Updating any collar with existing label prims to 8.3

On further exploring i found in the collar content that both scripts oc_label and oc_meshlabel have been installed. After deleting oc_meshlabel the label feature is working fine as expected which is a workaround, but a hassle for all the users with old collars who won't know how to fix it or those who are updating while wearing (and have it welded) cause you need either to turn off rlv or to remove the weld plus unlocking to delete the script.
After another test i have seen that those two scripts will be installed w/o checking if that collar build even has any label childprims or not.

Suggestions from me,
I) either make those scripts optional to install while updaing (same as e.g. oc_bell), or
II) let the updater check if there are any childprims called with starting "label~" for oc_label respective "meshlabel~" for oc_meshlabel to install only the right one.

@SilkieSabra
Copy link
Contributor

Is this a feature or a bug? I'm calling it a bug, at any rate it's a nuisance and if we can fix it we should.

@Pingout
Copy link
Collaborator

Pingout commented Jan 30, 2025

There are currently 2 ways to display Label Text on the suface of a collar. The first (legacy) method is to use a series of 12 linked prims, each with a specific prim name eg. Label 00 through Label 11. This older legacy system used the oc_label.lsl script to control the display. The second method came with the expanded use of mesh, some time around OpenCollar Version 6. This method used a multiple (6 or 8) face mesh object, named MeshLabel 00 through MeshLabel 03 which needed a new script to manage the text display, called oc_meshlabel.lsl
The second method had a number of improvements over the previous version, the first was a significant reduction in land impact and complexity. The second method also allowed for more letters to be displayed, up to 32 characters.
To maintain backward compatability, the OpenCollar Updaters have been shipped with both oc_label.lsl, and oc_meshlabel.lsl scripts in the installer. Unfortunately these two scripts are incompatible. Someone with a newer collar with a meshlabel will never see a problem as the oc_label script does not see the required prims.
Someone with the legacy system will need to remove the oc_meshlabel script to avoid the conflicting MeshLabel menu

Note: Prim names are shown without the Tilde character as this forum has a special use for that character

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants