Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransportImpl::peekFirstValidTxItem has unbounded loop #429

Open
thirtytwobits opened this issue Feb 2, 2025 · 2 comments
Open

TransportImpl::peekFirstValidTxItem has unbounded loop #429

thirtytwobits opened this issue Feb 2, 2025 · 2 comments

Comments

@thirtytwobits
Copy link
Contributor

While loop in this method has no time-bound exit criteria. A large number of expired frames will cause this method to consume a proportionally large amount of CPU time.
@thirtytwobits
Copy link
Contributor Author

Also found the same condition in sendNextFrameToMediaTxSocket

@pavel-kirienko
Copy link
Member

Our scheduler has no notion of execution time limits, but we could add a fixed number of frames to traverse before cutting the call short. This should be enough for MISRA/AUTOSAR compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavel-kirienko @thirtytwobits