Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Do auto-generated classes need to be final? #280

Open
pavel-kirienko opened this issue Feb 27, 2023 · 0 comments
Open

C++: Do auto-generated classes need to be final? #280

pavel-kirienko opened this issue Feb 27, 2023 · 0 comments

Comments

@pavel-kirienko
Copy link
Member

From Matrix:

  • I found myself needing to subclass a C++ class generated by Nunavut, then I discovered that the generated classes are marked final. Would it be frowned upon if I proposed to remove the final specifier or to make it optional? (inb4 fix your codebase rather than breaking nunavut)

  • I think this could be made optional but it does lower the availability of some optimizations and puts different constraints on the classes (e.g. the need for virtual destructors if non-trival, et-al). Can you open an issue against this so I can evaluate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant