Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaskWithState.process_get_state() shouldn't return process_data #14

Open
odscjames opened this issue Oct 9, 2024 · 0 comments
Open

TaskWithState.process_get_state() shouldn't return process_data #14

odscjames opened this issue Oct 9, 2024 · 0 comments

Comments

@odscjames
Copy link
Contributor

That encourages coders to think they can change process_data in the function, but they can't, as this function is not always called.

ProcessDataTask.process() function is the correct place to add things to process_data, but that means there needs to be some more complexity when it's used - and TaskWithState was designed to be easier to use.

So far no users of this class do do this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@odscjames